-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable tests for ghc 9 and promote ghcVersion
check
#2001
Conversation
This is very nice, thank you @jneira !! |
Hmm, afaics the unique module where i could remove CPP language pragma was haskell-language-server/ghcide/.hlint.yaml Lines 88 to 110 in ce15ff6
But hlint should warn about that, so surely i am missing something |
I've marked circleci job and the ubuntu test job for 9.0.1 as required |
We have a succesful run with tests included for ghc-9.0.1 and macos: https://github.com/haskell/haskell-language-server/pull/2001/checks?check_run_id=2997169971 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we still need CPP around imports and other non-expression sections
The test job for windows and ghc-9.0.1 is getting stuck in the last builds 😟 |
GhcVersion
datatype andghcVersion
function to ghcide to make it available to all the codebaseGHC90
version and removeGHC84
(as we dont support it anymore)